Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: add grpc.WithBlock to client config #8205

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented May 28, 2021

Description

Add WithBlock to client config.
Ref: https://etcd.io/docs/next/upgrades/upgrade_3_3/#upgrades-to--v3314
This is backwards-compatible with etcd 3.3.10.

Related Issue(s)

#8204

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required - website docs just say "version 3 and up"

Unit and endtoend tests ran locally with 3.3.10 and 3.3.14

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi added Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 28, 2021
@deepthi deepthi marked this pull request as ready for review May 29, 2021 00:05
@deepthi deepthi requested a review from rafael as a code owner May 29, 2021 00:05
@deepthi deepthi requested a review from vmg May 29, 2021 00:07
@deepthi deepthi merged commit 549e36a into vitessio:master Jun 1, 2021
@deepthi deepthi deleted the ds-etcd-client-withblock branch June 1, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants